You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
How to test changes / Special notes to the reviewer
Checklist
For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
Tests pass using the Chart Testing tool and the ct lint command.
Verify that the pinned chart-testing, yamllint, and yamale versions are compatible with each other and with Python 3.14 across all workflow paths (including matrix or reusable workflows if any).
Confirm that the specified versions for chart-testing, yamllint, and yamale are compatible with the pinned action version and Python 3.14 across all workflow jobs to avoid mismatches or unexpected behavior.
The same tool version pins are duplicated across workflows; consider centralizing via a reusable workflow or composite action to reduce drift and maintenance overhead.
The workflows pin chart-testing tool versions but do not set Helm timeout args used elsewhere. Ensure ct configs invoked by the action still apply the expected --timeout 500s to avoid flaky CI runs. (Ref 1, Ref 3)
- name: Set up chart-testinguses: helm/chart-testing-action@0d28d3144d3a25ea2cc349d6e59901c4ff469b3b # v2.7.0with:
version: '3.14.0'yamllint_version: '1.37.1'yamale_version: '6.0.0'
Reference reasoning: Existing ct configuration files set helm-extra-args: --timeout 500s for lint/install runs; aligning workflow-invoked chart-testing with these settings preserves consistent behavior.
Why: The suggestion correctly identifies that the specified chart-testing version 3.14.0 does not exist, which would cause the CI workflow to fail. This is a critical bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a follow-up to [1], to ensure that they work properly with Python 3.14 - see [2]
[1] #249
[2] https://github.com/redhat-developer/rhdh-chart/actions/runs/18350355942/job/52268343561?pr=248
Which issue(s) does this PR fix or relate to
—
How to test changes / Special notes to the reviewer
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes. The pre-commit Workflow will do this automatically for you if needed.pre-commithook.ct lintcommand.